Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Set up worker server #10814

Merged
merged 6 commits into from
Sep 17, 2024
Merged

refactor(core): Set up worker server #10814

merged 6 commits into from
Sep 17, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Sep 13, 2024

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 13, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments

packages/cli/src/errors/non-worker-instance-type.error.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/worker.ts Show resolved Hide resolved
packages/cli/src/scaling/worker-server.ts Show resolved Hide resolved
packages/cli/src/scaling/worker-server.ts Outdated Show resolved Hide resolved
packages/cli/src/scaling/worker-server.ts Show resolved Hide resolved
packages/cli/src/scaling/worker-server.ts Outdated Show resolved Hide resolved
packages/cli/src/scaling/worker-server.ts Show resolved Hide resolved
@ivov ivov requested a review from tomi September 17, 2024 07:46
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

cypress bot commented Sep 17, 2024

n8n    Run #6896

Run Properties:  status check passed Passed #6896  •  git commit 84feb1936b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review set-up-worker-server
Run status status check passed Passed #6896
Run duration 04m 35s
Commit git commit 84feb1936b: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 429
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 94aa680 into master Sep 17, 2024
73 of 78 checks passed
@ivov ivov deleted the set-up-worker-server branch September 17, 2024 08:14
MiloradFilipovic added a commit that referenced this pull request Sep 17, 2024
* master:
  refactor(core): Set up worker server (#10814)
  fix(Google Vertex Chat Model Node): Clean service account private key (#10770)
  test(core): Mock filesystem in tests (#10823)
  test(core): Fix license mock in worker test (#10824)
  ci: Ignore certain paths for e2e tests for PRs (no-changelog) (#10533)
  fix(editor): Render image binary-data using img tags (#10829)
  refactor(core): Move `instanceType` to `InstanceSettings` (no-changelog) (#10640)
  ci(benchmark): Always perform az login before teardown (#10827)
  fix: Prevent copying workflow when copying outside of canvas (#10813)
  fix: Fix telemetry causing console error (#10828)
  refactor: Remove unused disable directives from `nodes-base` (#10825)
  refactor(core): Remove unused disable directives from backend packages (#10826)
  chore: Upgrade to TypeScript 5.6 (#10822)
  fix(editor): Prevent clipboard XSS injection (#10805)
  refactor(core): Simplify createDeferredPromise, and add tests (no-changelog) (#10811)
  fix(HTTP Request Tool Node): Fix subsequent tool calls reusung the same options (#10808)
  fix(editor): Make expression edit modal read-only in executions view (#10806)
  refactor(core): Move push message types to a new shared package (no-changelog) (#10742)
  fix(editor): Make schema view search copy more clear (#10807)
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants